Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix Dropdown selection and JSON validation for dashboard - Closes #6423 #6426

Merged
merged 3 commits into from
May 14, 2021
Merged

Fix Dropdown selection and JSON validation for dashboard - Closes #6423 #6426

merged 3 commits into from
May 14, 2021

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 14, 2021

What was the problem?

This PR resolves #6423

How was it solved?

  • Fix the usage of useEffect
  • Add disabled for button
  • Add json validation and call disabled

How was it tested?

  • Add invalid JSON and check if button is disabled
  • Try to send different transactions and see they can be sent

@shuse2 shuse2 requested review from ishantiw and Incede May 14, 2021 12:28
@shuse2 shuse2 self-assigned this May 14, 2021
@Incede Incede self-requested a review May 14, 2021 13:13
@ManuGowda ManuGowda merged commit cd24525 into release/5.1.0 May 14, 2021
@ManuGowda ManuGowda deleted the 6423-fix_dropdown_and_json_validation branch May 14, 2021 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Incede Incede Incede approved these changes

@ishantiw ishantiw ishantiw approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuse2 @ishantiw @Incede @ManuGowda