Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix isHexString validation #8556

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Fix isHexString validation #8556

merged 5 commits into from
Jun 6, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Jun 5, 2023

What was the problem?

This PR resolves #8531

How was it solved?

  • Update validation logic to check length to be even

How was it tested?

  • Added unit test

@shuse2 shuse2 requested review from bobanm and mosmartin June 5, 2023 12:49
@shuse2 shuse2 self-assigned this Jun 5, 2023
@shuse2 shuse2 changed the base branch from development to release/6.0.0 June 5, 2023 12:49
@shuse2 shuse2 changed the title Fix Is HexString validation Fix isHexString validation Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #8556 (09c20f3) into release/6.0.0 (8b8df42) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 09c20f3 differs from pull request most recent head 9551b19. Consider uploading reports for the commit 9551b19 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8556   +/-   ##
==============================================
  Coverage          83.33%   83.33%           
==============================================
  Files                593      593           
  Lines              22334    22335    +1     
  Branches            3277     3277           
==============================================
+ Hits               18612    18613    +1     
  Misses              3722     3722           
Impacted Files Coverage Δ
elements/lisk-validator/src/validation.ts 98.21% <100.00%> (ø)

... and 3 files with indirect coverage changes

elements/lisk-validator/src/validation.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from bobanm June 6, 2023 04:30
@shuse2 shuse2 requested a review from bobanm June 6, 2023 07:00
@shuse2 shuse2 enabled auto-merge (squash) June 6, 2023 09:57
@shuse2 shuse2 merged commit 0ea3844 into release/6.0.0 Jun 6, 2023
@shuse2 shuse2 deleted the 8531-fix-validation branch June 6, 2023 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hex format validator allows empty and odd-length strings
3 participants