-
Notifications
You must be signed in to change notification settings - Fork 455
NFTModule.initGenesisState #8630
NFTModule.initGenesisState #8630
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6917-implement-nft-module #8630 +/- ##
=====================================================================
+ Coverage 83.84% 83.88% +0.03%
=====================================================================
Files 623 623
Lines 23164 23208 +44
Branches 3350 3360 +10
=====================================================================
+ Hits 19423 19467 +44
Misses 3741 3741
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a partial review, I would suggest until my comment in lines 302-316 of module.ts
gets some input from the research reviewers of the LIP (also feel free to comment on this).
…Substore and EscrowSubstore and adds checks to throw if UserSubstore and EscrowSubstore has additional entries for an NFT not contained in NFTSubstore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Now the code is much cleaner
What was the problem?
This PR resolves #8397
How was it solved?
Implemented NFTModule.initGenesisState.
How was it tested?
Implemented unit tests.