This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Align the token support methods to the lip #8631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosmartin
force-pushed
the
8505-align-token-support-methods-lip
branch
from
de3f8ba
to
b6997c0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8631 +/- ##
=================================================
- Coverage 83.34% 83.34% -0.01%
=================================================
Files 596 594 -2
Lines 22356 22363 +7
Branches 3292 3304 +12
=================================================
+ Hits 18633 18638 +5
- Misses 3723 3725 +2
|
shuse2
suggested changes
Jun 21, 2023
mosmartin
force-pushed
the
8505-align-token-support-methods-lip
branch
from
b6997c0
to
72ed80e
Compare
mosmartin
force-pushed
the
8505-align-token-support-methods-lip
branch
from
72ed80e
to
fd4c805
Compare
shuse2
suggested changes
Jun 26, 2023
mosmartin
force-pushed
the
8505-align-token-support-methods-lip
branch
from
020c8b6
to
3a5d368
Compare
Cleanup the comments Refactor the updates Refactor the methods and tests Update the tests Add unit test Add unit tests
mosmartin
force-pushed
the
8505-align-token-support-methods-lip
branch
from
3a5d368
to
3f12833
Compare
gkoumout
reviewed
Jul 11, 2023
shuse2
suggested changes
Jul 26, 2023
shuse2
suggested changes
Aug 1, 2023
shuse2
suggested changes
Aug 1, 2023
shuse2
reviewed
Aug 1, 2023
shuse2
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8505
How was it solved?
Aligned the token support methods to the lip
How was it tested?
Added unit tests