-
Notifications
You must be signed in to change notification settings - Fork 455
Update NFT module with additional checks and LIP updates #8635
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6917-implement-nft-module #8635 +/- ##
==================================================================
Coverage 83.84% 83.84%
==================================================================
Files 623 623
Lines 23159 23164 +5
Branches 3348 3350 +2
==================================================================
+ Hits 19417 19423 +6
+ Misses 3742 3741 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token module change should be a different PR targeting release/6.0.0 branch 🙏
Assuming above, token module part is not reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as per comment I reviewed only the NFT part.
I see that some tests are failing, do you have idea why that may be? |
yes, the tests were failing due to the incorrect setup of |
What was the problem?
This PR partially resolves #8580
How was it solved?
Update NFT module as specified
How was it tested?
Added unit tests