Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix build on branch feature/6917-implement-nft-module #8777

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Jul 27, 2023

What was the problem?

This PR resolves #8776

How was it solved?

Update interoperability send method usage in nft module per latest update from development branch

How was it tested?

Updated unit tests

@Incede Incede added this to the Sprint 100 milestone Jul 27, 2023
@Incede Incede requested review from shuse2 and has5aan July 27, 2023 05:21
@Incede Incede self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #8777 (af1a47b) into feature/6917-implement-nft-module (9902905) will increase coverage by 0.10%.
Report is 125 commits behind head on feature/6917-implement-nft-module.
The diff coverage is 90.56%.

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/6917-implement-nft-module    #8777      +/-   ##
=====================================================================
+ Coverage                              83.87%   83.97%   +0.10%     
=====================================================================
  Files                                    623      623              
  Lines                                  23245    23279      +34     
  Branches                                3366     3400      +34     
=====================================================================
+ Hits                                   19497    19549      +52     
+ Misses                                  3748     3730      -18     
Files Changed Coverage Δ
commander/src/base.ts 65.38% <0.00%> (-24.09%) ⬇️
commander/src/utils/genesis_creation.ts 69.23% <ø> (+38.46%) ⬆️
commander/test/helpers/transactions.ts 96.00% <ø> (-0.16%) ⬇️
elements/lisk-api-client/src/codec.ts 67.51% <ø> (ø)
elements/lisk-chain/src/schema.ts 100.00% <ø> (ø)
elements/lisk-p2p/src/schema.ts 100.00% <ø> (ø)
elements/lisk-transaction-pool/src/index.ts 0.00% <0.00%> (ø)
...sk-framework-chain-connector-plugin/src/schemas.ts 100.00% <ø> (ø)
...lisk-framework-faucet-plugin/src/plugin/schemas.ts 100.00% <ø> (ø)
...lugins/lisk-framework-forger-plugin/src/schemas.ts 100.00% <ø> (ø)
... and 133 more

... and 3 files with indirect coverage changes

@shuse2 shuse2 removed this from the Sprint 100 milestone Jul 27, 2023
@shuse2 shuse2 merged commit f5948ed into feature/6917-implement-nft-module Jul 28, 2023
10 checks passed
@shuse2 shuse2 deleted the 8776-fix-build branch July 28, 2023 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants