This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
NFT module can not lock an NFT #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #8992 +/- ##
==============================================
Coverage 84.35% 84.35%
==============================================
Files 650 650
Lines 24027 24027
Branches 3490 3490
==============================================
Hits 20268 20268
Misses 3759 3759 |
mjerkov
approved these changes
Sep 14, 2023
Incede
reviewed
Sep 15, 2023
Incede
approved these changes
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8956
How was it solved?
Updated
NFTModule.lockto throw if locking module isnft.How was it tested?
Implemented unit tests.