This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add missing unit tests for certificate generation and commit pool #9145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.1.0 #9145 +/- ##
==============================================
Coverage 84.35% 84.35%
==============================================
Files 655 655
Lines 24113 24113
Branches 3497 3497
==============================================
Hits 20340 20340
Misses 3773 3773 |
Phanco
reviewed
Nov 16, 2023
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
Phanco
reviewed
Nov 16, 2023
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
reviewed
Nov 22, 2023
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/engine/consensus/certificate_generation/commit_pool.spec.ts
Outdated
Show resolved
Hide resolved
|
Some cosmetic changes were left as is for better clarity |
ishantiw
approved these changes
Nov 23, 2023
Phanco
approved these changes
Nov 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7949
How was it solved?
Some points from original audit are now outdated due to new logic.
Incorrect test descriptions and parameters were updated as well as missing unit tests added.
How was it tested?
Added missing tests