Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update Default CCU Fee #9153

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Update Default CCU Fee #9153

merged 8 commits into from
Nov 24, 2023

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Nov 24, 2023

What was the problem?

This PR resolves #9147

How was it solved?

  1. Updated ccuFee to 0 as default
  2. When ccuFee is 0, computeMinFee is used
  3. All examples and test have suggested 500000 fee

How was it tested?

Test cases added

@Phanco Phanco requested a review from ishantiw November 24, 2023 09:11
@Phanco Phanco marked this pull request as ready for review November 24, 2023 09:12
@Phanco Phanco changed the base branch from development to hotfix/6.0.1 November 24, 2023 09:12
@Phanco Phanco changed the base branch from hotfix/6.0.1 to development November 24, 2023 09:14
@Phanco Phanco changed the base branch from development to hotfix/6.0.1 November 24, 2023 09:16
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #9153 (e6a7c5d) into hotfix/6.0.1 (f825978) will increase coverage by 0.01%.
Report is 1 commits behind head on hotfix/6.0.1.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix/6.0.1    #9153      +/-   ##
================================================
+ Coverage         83.51%   83.53%   +0.01%     
================================================
  Files               606      606              
  Lines             22826    22839      +13     
  Branches           3364     3367       +3     
================================================
+ Hits              19064    19078      +14     
+ Misses             3762     3761       -1     
Files Coverage Δ
...nder/src/bootstrapping/commands/blockchain/hash.ts 94.28% <100.00%> (+0.16%) ⬆️
...ain-connector-plugin/src/chain_connector_plugin.ts 79.00% <100.00%> (+0.76%) ⬆️
...sk-framework-chain-connector-plugin/src/schemas.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@Phanco Phanco self-assigned this Nov 24, 2023
@Phanco Phanco requested a review from ishantiw November 24, 2023 11:40
@Phanco Phanco requested a review from ishantiw November 24, 2023 14:43
@ishantiw ishantiw merged commit aabf4b6 into hotfix/6.0.1 Nov 24, 2023
11 checks passed
@ishantiw ishantiw deleted the 9147-update-ccuFee-default branch November 24, 2023 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute ccuFee property of chain connector plugin and use a safe value by default
3 participants