This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Major update of PoS unit tests #9193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #9193 +/- ##
===============================================
+ Coverage 84.66% 84.68% +0.02%
===============================================
Files 657 657
Lines 24071 24071
Branches 3492 3492
===============================================
+ Hits 20380 20385 +5
+ Misses 3691 3686 -5
|
shuse2
approved these changes
Jan 4, 2024
ishantiw
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8020
How was it solved?
This PR addresses comments from @gkoumout on the following tests.
...and adds several further code improvements.
Since this PR is already big, it does NOT address the comments about:
I propose these to be handled in a separate PR.
How was it tested?
All unit tests pass 👌🏻