Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Accounts module assigns undefined logger to Votes logic #3224

Closed
2snEM6 opened this issue Mar 29, 2019 · 0 comments
Closed

Accounts module assigns undefined logger to Votes logic #3224

2snEM6 opened this issue Mar 29, 2019 · 0 comments
Assignees

Comments

@2snEM6
Copy link
Contributor

2snEM6 commented Mar 29, 2019

Expected behavior

Logger should be correctly assigned to Vote.js instance

Actual behavior

When Accounts module tries to initialize Vote's logic, logger comes from old scope format placed at scope's root. Now logger is under scope.components so it's assigning undefined.

See here:

https://github.com/LiskHQ/lisk/blob/92d658c7c12d3ccb863a79ea977c93800ada8746/framework/src/modules/chain/submodules/accounts.js#L70

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

shuse2 added a commit that referenced this issue Mar 29, 2019
…fined_logger_votes_logic

Fix undefined logger in Votes logic - Closes #3224
@shuse2 shuse2 closed this as completed Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants