Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 'id' property in model objects #283

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Conversation

lace00
Copy link
Contributor

@lace00 lace00 commented Jul 13, 2021

The current version supports '_id' property only, with this change it can handle 'id' as well

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #283 (76e3627) into master (9c2413a) will decrease coverage by 0.04%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
- Coverage     57.72%   57.67%   -0.05%     
- Complexity      727      729       +2     
============================================
  Files           131      131              
  Lines          5417     5418       +1     
  Branches        454      454              
============================================
- Hits           3127     3125       -2     
- Misses         2092     2094       +2     
- Partials        198      199       +1     
Impacted Files Coverage Δ
.../main/kotlin/org/litote/kmongo/util/MongoIdUtil.kt 86.66% <90.90%> (-1.97%) ⬇️
...litote/kmongo/coroutine/CoroutineClientSessions.kt 50.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2413a...76e3627. Read the comment docs.

@zigzago
Copy link
Member

zigzago commented Jul 17, 2021

Thank you for the PR. Could you add a system property like "kmongo.id.enabled" that would activate this feature. (disabled by default). I would prefer to enable this as "feature preview" first.

@lace00
Copy link
Contributor Author

lace00 commented Sep 1, 2021

Thank you for the PR. Could you add a system property like "kmongo.id.enabled" that would activate this feature. (disabled by default). I would prefer to enable this as "feature preview" first.

@zigzago I added the "kmongo.id.enabled" system property.

@zigzago zigzago merged commit 1b50492 into Litote:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants