UUIDSerializer: Cast to parent type to deserialize a UUID within a list #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithin a list. The UUIDSerializer's deserializer will fail with a `ClassCastException` when the UUID is embedded in a list (e.g., `val foo: Collection<@contextual UUID> = emptyList()`). The decoder in this example is a `ListDecoder` rather than the expected `BsonFlexibleDecoder` triggering the exception. Both, however, are `FlexibleDecoder` objects and the reader field is declared there. Updated the cast to this parent type, resolving the issue.
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UUIDSerializer's deserializer will fail with aClassCastExceptionwhen the UUID is embedded in a list (e.g.,val foo: Collection<@Contextual UUID> = emptyList()). The decoder in this example is aListDecoderrather than the expectedBsonFlexibleDecodertriggering the exception. Both, however, areFlexibleDecoderobjects and thereaderfield is declared there. Updated the cast to this parent type, resolving the issue. The existing tests pass with this change.If you need more info, please let me know.