Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccessary returns #273

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Remove unneccessary returns #273

wants to merge 3 commits into from

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Oct 4, 2023

Functions which set self.attribute no longer return self.attribute.
i.e. you no longer do object.attribute = object.method() if object.method() sets self.attributeanyway

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant