Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: adjust clang-format rules #2186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

Description

Adjust clang-format rules, mostly to adjust break after return type behavior.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member Author

See https://github.com/LizardByte/Sunshine/actions/runs/8072315274/job/22053784930 for all changes that will be applied when this PR is ready to merge.

@Hazer
Copy link
Member

Hazer commented Jun 1, 2024

I made a proposal of changes in:
#2623

@ReenigneArcher ReenigneArcher force-pushed the style-adjust-clang-format-rules branch from bc96c71 to 534843f Compare June 1, 2024 13:31
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.98%. Comparing base (5cea1e1) to head (90f6aec).
Report is 63 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2186   +/-   ##
======================================
  Coverage    8.98%   8.98%           
======================================
  Files          95      95           
  Lines       17304   17304           
  Branches     8232    8232           
======================================
  Hits         1555    1555           
+ Misses      12884   12881    -3     
- Partials     2865    2868    +3     
Flag Coverage Δ
Linux 6.78% <ø> (ø)
Windows 4.16% <ø> (ø)
macOS-12 10.09% <ø> (ø)
macOS-13 10.01% <ø> (ø)
macOS-14 10.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the style-adjust-clang-format-rules branch from 9f7a6a8 to 938eeb6 Compare June 1, 2024 19:41
.clang-format Outdated
BreakBeforeTernaryOperators: false
BreakConstructorInitializers: AfterColon
BreakInheritanceList: AfterColon
ColumnLimit: 0
ColumnLimit: 120
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really work the way I wish it would... probably revert this to 0

Suggested change
ColumnLimit: 120
ColumnLimit: 0

@FrogTheFrog
Copy link
Collaborator

FrogTheFrog commented Jul 7, 2024

Could we get this curly bracket on a new line? It looks very ugly in my opinion. Moving it still looks ugly, but less so...
image

@ReenigneArcher ReenigneArcher force-pushed the style-adjust-clang-format-rules branch from 938eeb6 to 5f931d2 Compare July 7, 2024 17:22
Co-Authored-By: Vithorio Polten <[email protected]>
@ReenigneArcher ReenigneArcher force-pushed the style-adjust-clang-format-rules branch from 5f931d2 to 90f6aec Compare July 7, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants