refactor(ui): break down config.html into smaller pieces #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Hazer
force-pushed
the
refactor/big-chungus-expurgus
branch
from
4d3ffb6
to
3aa823c
Compare
ReenigneArcher
requested changes
May 12, 2024
Hazer
commented
May 12, 2024
Hazer
commented
May 12, 2024
Hazer
commented
May 12, 2024
Hazer
commented
May 12, 2024
src_assets/common/assets/web/configs/tabs/audiovideo/NewDisplayOutputSelector.vue
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94%
=========================================
Files 87 87
Lines 17673 17673
Branches 8399 8399
=========================================
Hits 1227 1227
- Misses 13717 15761 +2044
+ Partials 2729 685 -2044
Flags with carried forward coverage won't be shown. Click here to find out more. |
ReenigneArcher
requested changes
May 12, 2024
src_assets/common/assets/web/configs/tabs/encoders/AmdAmfEncoder.vue
Outdated
Show resolved
Hide resolved
src_assets/common/assets/web/configs/tabs/encoders/IntelQuickSyncEncoder.vue
Outdated
Show resolved
Hide resolved
src_assets/common/assets/web/configs/tabs/encoders/NvidiaNvencEncoder.vue
Outdated
Show resolved
Hide resolved
src_assets/common/assets/web/configs/tabs/encoders/SoftwareEncoder.vue
Outdated
Show resolved
Hide resolved
src_assets/common/assets/web/configs/tabs/encoders/VideotoolboxEncoder.vue
Outdated
Show resolved
Hide resolved
|
@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed. |
Breaks that big chungus of a vue file into smaller readable vue files, Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms, `PlatformLayout` for slotted platform layout, making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
ReenigneArcher
force-pushed
the
refactor/big-chungus-expurgus
branch
from
b810b45
to
92dfaa4
Compare
ReenigneArcher
approved these changes
May 13, 2024
11 tasks
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
…2491) Co-authored-by: ReenigneArcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements,
$tpfor i18n$tbut knows platforms,PlatformLayoutfor slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.configs/tabs/audiovideo/NewDisplayOutputSelector.vuewill be used in feat(ui): list available displays withselect#2490configs/tabs/audiovideo/DisplayDeviceOptions.vuewas created as boilerplate so Add new API to modify display devices for Windows #2032 can use to place the new div with their changesWe can improve further by pushing more logic into each Component, instead of parsing and filtering data in
config.html, but I wanted to avoid refactoring the load/save part in this PR.PS: Fixed
_common.*_cmdlabels in General Tab.Screenshot
No visual changes.
Type of Change
Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.