Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win/cmake): file(TO_NATIVE_PATH) broke in latest cmake #3152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Sep 6, 2024

Description

file(TO_NATIVE_PATH) broke in latest cmake.

At least in the scoop version of cmake-3.30.3 slashes don't get reversed.
cmake_path(CONVERT TO_NATIVE_PATH_LIST) works fine and this seems to be the intended way to do it anyway. "New in version 3.20."

Screenshot

Capture

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

sonarcloud bot commented Sep 6, 2024

@ReenigneArcher
Copy link
Member

"New in version 3.20."

Currently, we're specifying 3.18 as the minimum required.

cmake_minimum_required(VERSION 3.18)

I'm not sure if it's possible to dynamically set the minimum version, based on the OS or whatever. I'm fine with bumping it though. All our linux builds will compile cmake if it's lower 3.25 right now anyway. Could possibly cause issues for anyone self compiling on older LTS releases.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.70%. Comparing base (cdc2d1b) to head (398cfee).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3152      +/-   ##
=========================================
- Coverage    9.82%   9.70%   -0.13%     
=========================================
  Files         101      77      -24     
  Lines       17990   14074    -3916     
  Branches     8411    6460    -1951     
=========================================
- Hits         1768    1366     -402     
+ Misses      13339   10088    -3251     
+ Partials     2883    2620     -263     
Flag Coverage Δ
Linux ?
Windows 5.06% <ø> (ø)
macOS-12 10.76% <ø> (+0.01%) ⬆️
macOS-13 10.67% <ø> (+0.01%) ⬆️
macOS-14 10.96% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants