release: fix tests not running on aarch64-darwin
#1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
force-pushed
the
aarch64-tests
branch
3 times, most recently
from
07f619a
to
52ea390
Compare
|
IIRC the last time I tried to do this there was some issue. Maybe the schema was wrong or something? I assume We could probably get rid of some of the existing test jobs as redundant to this, but maybe it’s fine. |
|
As far as I'm aware, Another schema change is in bf3e8e1 where previously we were generating I've removed the new test jobs and replaced the commands in the existing |
We decided to drop this example as the package is not available in Nixpkgs and we won't be able to import it easily and keep this example evaluating as a useful smoke test. The code in this example is already documented under `services.ofborg.*` so any interested users can still find out how to set up `ofborg`.
emilazy
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cleaned up
release.nixby removing package related jobs which aren't run as far as I'm aware and already live in nixpkgs.I've also exposed the docs and tests in
flake.nixunderpackagesandchecksrespectively which means they should get tested withnix flake checkand allows you to build individual tests withnix buildi.e.nix build nix-darwin#checks.aarch64-darwin.users-groups