build: Use NPM v7 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `npm install` to migrate `package-lock.json` format to v2
Due to a bug in NPM v7, `npm outdated` fails when kolmafia-types is aliased. To work around this, we install `kolmafia-types` by its name, and TypeScript's `compilerOptions.paths` field is used to resolve `kolmafia` to `kolmafia-types`. We also install: - kolmafia-types 0.1.1 (updated) - tsconfig-paths which is needed to run tests with Jasmine + ts-node See also: - GitHub issue for the NPM v7 bug: npm/cli#2800 - Description of the workaround: https://github.com/pastelmind/kolmafia-types/tree/v0.1.1#method-2-use-a-custom-path-to-resolve-kolmafia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM 7 is the latest version of NPM. I ran
npm installto updatepackage-lock.jsonformat to v2.NPM v7 has a bug with aliased packages when running
npm outdated. To avoid this, I installed kolmafia-types without aliasing, and update TypeScript's config to resolvekolmafiatokolmafia-types.I also installed tsconfig-paths to make the workaround work with ts-node.