Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about mismatched dashboard and core version #23

Closed
CheatCod opened this issue Oct 2, 2022 · 2 comments · Fixed by #120
Closed

Warn about mismatched dashboard and core version #23

CheatCod opened this issue Oct 2, 2022 · 2 comments · Fixed by #120
Assignees
@Arcslogger @NicholasLin718
Labels
enhancement New feature or request
Milestone
0.4.1

Comments

@CheatCod
Copy link
Member

CheatCod commented Oct 2, 2022

No description provided.

@Ynng
Copy link
Member

Ynng commented Oct 2, 2022 •
edited
Loading

dashboard should check the version of backend and warn toast if there is a minor/patch version mismatch, and warn with a modal if there is major version mismatch.

@Ynng Ynng added the enhancement New feature or request label Jan 15, 2023
@Ynng Ynng added this to Lodestone Jan 15, 2023
@github-project-automation github-project-automation bot moved this to Draft/Backlog in Lodestone Jan 15, 2023
@Ynng Ynng moved this from 🗃 Draft/Backlog to 🔖 Ready to Start in Lodestone Jan 19, 2023
@Ynng Ynng added this to the 0.4.1 milestone Jan 19, 2023
@Ynng Ynng changed the title Add semver Warn about mismatched dashboard and core version Jan 21, 2023
@Ynng
Copy link
Member

Ynng commented Jan 21, 2023

Also need design from @Arcslogger

@NicholasLin718 NicholasLin718 mentioned this issue Jan 22, 2023
Merged
@Ynng Ynng linked a pull request Jan 23, 2023 that will close this issue
Mismatch version modal and toast #120
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to Start to ✔ Done in Lodestone Jan 23, 2023
Ynng pushed a commit that referenced this issue Jul 14, 2023
@CheatCod
Fix typo (#23)
b6d10c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arcslogger Arcslogger

@NicholasLin718 NicholasLin718

Labels
enhancement New feature or request
Projects
Lodestone
Status: ✔ Done
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

Mismatch version modal and toast Lodestone-Team/lodestone
4 participants
@Ynng @CheatCod @Arcslogger @NicholasLin718