Support coloration schemes on non-chrome browsers #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=========================================
- Coverage 3.2% 2.75% -0.45%
=========================================
Files 5 6 +1
Lines 125 145 +20
=========================================
Hits 4 4
- Misses 121 141 +20
Continue to review full report at Codecov.
|
|
This looks to be dead on arrival. I cut the PR before the transition between redux-logger@2.* and 3.
… On Jul 3, 2017, at 11:11 AM, Leonardo Couto ***@***.***> wrote:
Is someone looking into this ? Is a nice feature, nowadays the color formatting does not look good on Firefox.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#203 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE6wCa5zdGaiz6pBIahouPd27e51c39Rks5sKQSRgaJpZM4MFNgi>.
|
|
Resending to rest of the list.
This looks to be dead on arrival. I cut the PR before the transition between redux-logger 2 and 3.
… On Jul 3, 2017, at 11:11 AM, Leonardo Couto ***@***.***> wrote:
Is someone looking into this ? Is a nice feature, nowadays the color formatting does not look good on Firefox.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#203 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE6wCa5zdGaiz6pBIahouPd27e51c39Rks5sKQSRgaJpZM4MFNgi>.
|
imevro
requested changes
Aug 16, 2017
imevro
changed the title
|
Would this PR support colors in node (i.e. when testing with Mocha or Jest)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on Chrome 56, Firefox 51, and Safari 10. I don't have access to a machine running Edge or IE, but this should also disable coloration and the formatting tokens by default for them.
#170