Fix miri CI #231
Merged
Fix miri CI #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now the default.
Lokathor
approved these changes
Apr 1, 2024
zachs18
added a commit
to zachs18/bytemuck
that referenced
this pull request
Apr 2, 2024
* Remove -Zmiri-tag-raw-pointers It is now the default. * Remove workaround for miri/2423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of rust-lang/miri#2275, raw pointer tagging is now always enabled, and since rust-lang/miri#3339 the
-Zmiri-tag-raw-pointersCLI option has been removed, causing CI failures.Also, rust-lang/miri#2423 got fixed recently, so remove the workaround for it (that was also making miri CI fail lol).