Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEST-314: DRY workflows #11

Merged
merged 121 commits into from
Jun 19, 2022
Merged

NEST-314: DRY workflows #11

merged 121 commits into from
Jun 19, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Jun 14, 2022

@Piedone
Grammar
bc86549
@Piedone
Adding Build and Test workflow from OSOCE without changes
1c5949f
@Piedone
Making workflow use inputs instead of the original matrix
3c10ef0
@Piedone
Proper name for workflows
8990a51
@Piedone
Removing timout config as it's not necessarily a good default for all…
c3df983 
… projects
@Piedone
Removing strategy because that should come from the calling workflow
4442109
@Piedone
Making verbosity configurable
772b0bc
@Piedone
Switching verbosity default to quiet, like it was in the original wor…
425f037 
…kflow
@Piedone
Fixing docs
f88cacc
@Piedone
Fixing verbosity input
25d296b
@Piedone
Fixing directory input too
2ebdd9c
@Piedone
Going back to a different verbosity switch
ffadb0a
@Piedone
Move workflow to actions
efd1dad
@Piedone
Making former workflow into a proper action
020752c
@Piedone
Typo
c05cde5
@Piedone
Moving back to workflow
d97ac11
@Piedone
Adding matrix support to the workflow
b48b89a
@Piedone
Fixing syntax errors
8aa46bf
@Piedone
Fixing matrix references
0e1d7f6
@Piedone
Some steps shouldn't run actually always
da7b0cf
@Piedone
Using a matrix for a build directory is excessive and can be achieved…
e05ea2b 
… in OSOCE with concurrent jobs
@Piedone
Syntax fix
1a5cbd6
@Piedone
Parameter for .NET version
8b05cb4
@Piedone
Update checkout and setup-dotnet versions
7f37cf0
@Piedone
Factoring out .NET setup to separate action
a5dff7f
@Piedone
Fix syntax
35f92cc
@Piedone
Fixing action path
fce5e07
@Piedone
And again
f3c2496
@Piedone
Syntax fix
4b053dd
@Piedone
Movig build step to its own action too
deeff26
sarahelsaig
sarahelsaig requested changes Jun 18, 2022
View reviewed changes
.github/actions/build-dotnet/action.yml Show resolved Hide resolved
.github/actions/build-dotnet/action.yml Outdated Show resolved Hide resolved
.github/actions/build-dotnet/action.yml Outdated Show resolved Hide resolved
.github/actions/build-dotnet/build.ps1 Outdated Show resolved Hide resolved
.github/actions/build-dotnet/build.ps1 Outdated Show resolved Hide resolved
.github/actions/setup-sql-server/setup-sql-server.ps1 Show resolved Hide resolved
.github/actions/setup-sql-server/wait-for-sql-server.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/action.yml Show resolved Hide resolved
.github/actions/test-dotnet/action.yml Outdated Show resolved Hide resolved
.github/actions/test-dotnet/action.yml Show resolved Hide resolved
Piedone and others added 24 commits June 18, 2022 23:39
@Piedone @sarahelsaig
Grammar
1769cd0 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone @sarahelsaig
Typo
b3f0e4b 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone @sarahelsaig
Grammar
c891d29 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone
Message clarification
64618b3
@Piedone @sarahelsaig
Description clarification
c83df3a 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone
Testing env var changes from a previous action persisting
d843c78
@Piedone @sarahelsaig
Trailing empty line
8527f5e 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone @sarahelsaig
Trailing empty line
91e299f 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone
Revert "Testing env var changes from a previous action persisting"
b05a169 
This reverts commit d843c78.
@Piedone
Differently testing env var changes from a previous action persisting
62216d7
@Piedone
More env var propagation testing
3da50a0
@Piedone
More PS-like and semantic normal and error output handling
98e1ce5
@Piedone
Forgot that this isn't bash
762b6ad
@Piedone
Forgot how variables work in PS
5d45635
@Piedone
The hard part of docs is reading them
b05a5e2
@Piedone
Fixing syntax
9ef8dac
@Piedone
Again
fada06c
@Piedone
Maybe without quotes, then?
af10f63
@Piedone
Apparently Write-Output is not needed
038083e
@Piedone
Perhaps we can't use spaces
f5d286f
@Piedone @sarahelsaig
Safer Test Results name
9a8e4be 
Co-authored-by: Dávid El-Saig <[email protected]>
@Piedone
Removing debug code
6f759f8
@Piedone
Docs
0814223
@Piedone
Splatting build.ps1 switches
814f4ee
sarahelsaig
sarahelsaig reviewed Jun 19, 2022
View reviewed changes
.github/actions/setup-dotnet/action.yml Outdated
run: |
$Env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE = "true"
$Env:DOTNET_CLI_TELEMETRY_OPTOUT = "true"
$Env:SOMETHING_ELSE_JUST_FOR_ME = "hehe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@sarahelsaig sarahelsaig merged commit a5c2c6a into dev Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig approved these changes

@0liver 0liver 0liver left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piedone @0liver @sarahelsaig