OSOE-580: Custom analyzer rule for parameter and variable name styling #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenedekFarkas
commented
Jun 24, 2024
| @@ -8,4 +8,4 @@ $rootDirectory = (Test-Path -Path $testDirectory) ? $testDirectory : $Directory | |||
| Get-ChildItem $rootDirectory -Recurse | | |||
| Where-Object { $PSItem.Name -eq 'FailureDumps' } | | |||
| ForEach-Object { $PSItem.GetDirectories() } | | |||
| ForEach-Object { Move-Item $PSItem.FullName "$Directory/FailureDumps/${_.Name}" } | |||
| ForEach-Object { Move-Item $PSItem.FullName "$Directory/FailureDumps/$($PSItem.Name)" } | |||
There was a problem hiding this comment.
FYI this is a functional change, not just cosmetic. Variable names enclosed in braces are used to be able to use special characters in the variable name, so it won't behave the same as $_.Name (or $PSItem.Name). I also removed usages of braced variables in other files.
Idea: Add an analyzer that detects that braced variables are used unnecessarily, which is basically when you don't have a special character enclosed in the braces.
sarahelsaig
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-580