Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTProtoSender: Dont try to reconnenct in background when auto_reconnect is not available #4350

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

JavadZahedi
Copy link

I made this PR to fix this issue:
#4092

Copy link
Member

@Lonami Lonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_start_reconnect is called from separate tasks. Raising the error there won't let you catch it, and the library will appear to freeze.

Please make sure to try out the changes before I accept. You can edit the code to randomly force an error (maybe check when a file exists, and create the file to trigger it), for example, and see if it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants