Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle callable from_users for NewMessage events #4456

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

Handle callable from_users for NewMessage events #4456

wants to merge 1 commit into from

Conversation

mehdiirh
Copy link

@mehdiirh mehdiirh commented Sep 4, 2024

No description provided.

@Lonami
Copy link
Member

Lonami commented Sep 4, 2024

I'd prefer to avoid new features in v1. What would be the use case for this?

@mehdiirh
Copy link
Author

mehdiirh commented Sep 7, 2024

Hi
Retrieving eligible users dynamically from the database, instead of hard coding them. like admins

@Lonami
Copy link
Member

Lonami commented Sep 7, 2024

Why not make the call directly? This PR doesn't support async, and after it's set, if it changes later, it won't re-fetch them either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehdiirh @Lonami