[V2] Refactor sender #4484
Open
[V2] Refactor sender #4484
+82
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please motivate or explain the changes further. It's a bit difficult to get an overview on what the goal is. |
|
Sender is not working properly, it sometimes raises RuntimeError("got response for unsent request") and bad msg id, I tried to solve request queuing using queue |
Lonami
reviewed
Oct 12, 2024
Comment on lines
+237
to
+238
| request = await self._requests.get() | ||
| await self._try_fill_write(request) |
There was a problem hiding this comment.
Network should be able to run even if there are no requests to make. This will block until there is one which does not seem correct.
| _mtp_buffer=bytearray(), | ||
| _requests=[], | ||
| _request_event=Event(), | ||
| _requests=Queue(1), |
There was a problem hiding this comment.
I'm not sure why there's a limit of a single request. This does enable backpressure, but it might make it harder for the library to be able to combine multiple requests into a single container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one todo, the branch is not ready yet, but the main part is ready for review