Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New engine #189

Merged
merged 3 commits into from
Jan 20, 2020
Merged

New engine #189

merged 3 commits into from
Jan 20, 2020

Conversation

serg-pushkarev
Copy link
Contributor

No description provided.

matrosov and others added 3 commits December 10, 2017 21:39
@matrosov
Update ffsparser.cpp
d380888
@serg-pushkarev
Merge pull request #1 from LongSoft/new_engine
b7563ec 
New engine
@serg-pushkarev
fix FIT table header checksum calculation
aefd2eb 
the CsFlag field should not be set to 0 when calculating the checksum
@NikolajSchlej
Copy link
Collaborator

Any comments on why this kind of calculation is actually right, and the one we have today is wrong?

@serg-pushkarev
Copy link
Contributor Author

Source code of FitGen utility:
https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Intel/Tools/FitGen/FitGen.c (line 2458).
The checksum takes into account the C_V bit (CsFlag).

@vit9696 vit9696 merged commit 516949a into LongSoft:new_engine Jan 20, 2020
@slavonnet slavonnet mentioned this pull request Oct 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serg-pushkarev @NikolajSchlej @vit9696 @matrosov