Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Last UEFIFormSet at end of file #11

Closed
DeathBringer opened this issue Oct 9, 2018 · 5 comments
Closed

Last UEFIFormSet at end of file #11

DeathBringer opened this issue Oct 9, 2018 · 5 comments

Comments

@DeathBringer
Copy link

DeathBringer commented Oct 9, 2018 •
edited
Loading

If last UEFIFormSet is at the end of the file, then it is considered incorrect and dropped.
This also applies to UEFIStringPackages
Replace in file UEFI.cpp
16) < buffer.size()
with
16) <= buffer.size()
@DeathBringer DeathBringer changed the title Last UEFIFormSet at end of file deleted Oct 9, 2018
@DeathBringer DeathBringer reopened this Oct 9, 2018
@DeathBringer DeathBringer changed the title deleted Last UEFIFormSet at end of file Oct 9, 2018
@vit9696
Copy link

vit9696 commented Oct 9, 2018

There are two findings of 16) < buffer.size in UEFI.cpp, and even if there were less, the description is not clear enough in regards to the bug. Could you provide a test file?

@DeathBringer
Copy link
Author

DeathBringer commented Oct 9, 2018 •
edited
Loading

Patch two cases.
Attach source (binary) & result (text) file and I'll show you a bug.

@vit9696
Copy link

vit9696 commented Oct 10, 2018

I am afraid you forgot to include the attachments.

@DeathBringer
Copy link
Author

No, I'm waiting attachments from you.

@vit9696
Copy link

vit9696 commented Oct 11, 2018

Saw it & fixed.

@vit9696 vit9696 closed this as completed Oct 11, 2018
denskop pushed a commit to denskop/Universal-IFR-Extractor that referenced this issue Apr 24, 2019
@vit9696
Add a workaround for LongSoft#11
7a97f50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vit9696 @DeathBringer