Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show carb absorption data for the past 24 hours #738

Closed
wants to merge 3 commits into from

Conversation

bharat
Copy link

@bharat bharat commented Jun 14, 2018

This resolves #681

@ps2
Copy link
Collaborator

ps2 commented Jun 21, 2018

We still need to show a daily total. Also, we only cache insulin data for 24 hours, so there can be inaccuracies in ICE data within DIA of the 24-hour limit.

@bharat
Copy link
Author

bharat commented Jun 21, 2018

Good point. I can calculate and show the daily total, but before I do that- do you think that the inaccuracies are a blocker? Should I change it to 18 hours not 24 to avoid that problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants