_get_exp_summary() fails on LabMember table

[jguides]

I get an error when attempting to delete the entry in the LabMember table with my name. This entry currently lacks my username, which prevents me from deleting from other lab tables. I would like to delete the entry so I can reinsert it with my username.

However, when I run (LabMember & {"lab_member_name": "Jennifer Guidera"}).delete(), I get the error:

Error stack

`---------------------------------------------------------------------------
DataJointError                            Traceback (most recent call last)
Cell In[48], line 1
----> 1 (LabMember & {"lab_member_name": "Jennifer Guidera"}).delete()

File ~/Src/spyglass/src/spyglass/utils/dj_mixin.py:489, in SpyglassMixin.delete(self, force_permission, *args, **kwargs)
    487 def delete(self, force_permission=False, *args, **kwargs):
    488     """Alias for cautious_delete, overwrites datajoint.table.Table.delete"""
--> 489     self.cautious_delete(force_permission=force_permission, *args, **kwargs)

File ~/Src/spyglass/src/spyglass/utils/dj_mixin.py:450, in SpyglassMixin.cautious_delete(self, force_permission, *args, **kwargs)
    447 start = time()
    449 if not force_permission:
--> 450     self._check_delete_permission()
    452 merge_deletes = self.delete_downstream_merge(
    453     dry_run=True,
    454     disable_warning=True,
    455     return_parts=False,
    456 )
    458 safemode = (
    459     dj.config.get("safemode", True)
    460     if kwargs.get("safemode") is None
    461     else kwargs["safemode"]
    462 )

File ~/Src/spyglass/src/spyglass/utils/dj_mixin.py:373, in SpyglassMixin._check_delete_permission(self)
    366     logger.warn(  # Permit delete if no session connection
    367         "Could not find lab team associated with "
    368         + f"{self.__class__.__name__}."
    369         + "\nBe careful not to delete others' data."
    370     )
    371     return
--> 373 sess_summary = self._get_exp_summary()
    374 experimenters = sess_summary.fetch(self._member_pk)
    375 if None in experimenters:
    376     # TODO: Check if allow delete of remainder?

File ~/Src/spyglass/src/spyglass/utils/dj_mixin.py:325, in SpyglassMixin._get_exp_summary(self)
    320 format = dj.U(self._session_pk, self._member_pk)
    321 sess_link = self._session_connection.join(
    322     self.restriction, reverse_order=True
    323 )
--> 325 exp_missing = format & (sess_link - SesExp).proj(**empty_pk)
    326 exp_present = format & (sess_link * SesExp - exp_missing).proj()
    328 return exp_missing + exp_present

File ~/mambaforge/envs/spyglass/lib/python3.9/site-packages/datajoint/expression.py:440, in QueryExpression.proj(self, *attributes, **named_attributes)
    438     pass  # all ok
    439 try:
--> 440     raise DataJointError(
    441         "Attribute `%s` already exists"
    442         % next(
    443             a
    444             for a in compute_map
    445             if a in attributes.union(rename_map).union(replicate_map)
    446         )
    447     )
    448 except StopIteration:
    449     pass  # all ok

DataJointError: Attribute `lab_member_name` already exists`

[CBroz1]

Oops! This looks like an edge case of the cautious_delete process. In the short term, can you insert with the update flag to add your username?

[jguides]

Yes, this worked. Thanks Chris! I will leave this issue open since the underlying problem still exists.

[CBroz1]

This was an issue because generating the experimenter/session summary failed when the table called already had an experimenter field. This can only occur on table about personnel and not tables associated with sessions, so these will be skipped in the permission check. In my solve, I'll return Table * Session.Experimenter from _get_exp_summary in the special case where this is called on a personnel table.