Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaces once with on to allow multiple connect events after disconnect #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replaces once with on to allow multiple connect events after disconnect #8

wants to merge 1 commit into from

Conversation

acdaniel
Copy link

No description provided.

@acdaniel acdaniel mentioned this pull request Nov 20, 2016
Open
@bradfol
Copy link
Contributor

bradfol commented Jul 13, 2017

Maybe the listener setup should be moved from the constructor to the connect method. That way it still retains the existing event behavior when reconnects occur, but will still allow for your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acdaniel @bradfol