fix UnicodeDecodeError

#485 (comment)
Louisvdw · Apr 25, 2023 · 017df8a · 017df8a
1 parent a32c738
commit 017df8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/etc/dbus-serialbattery/config.default.ini b/etc/dbus-serialbattery/config.default.ini
@@ -126,6 +126,7 @@ DC_CURRENT_LIMIT3_FRACTION = 0.5
 
 ; --------- Time-To-Go ---------
 ; Description: Calculates the time to go shown in the GUI
+;              Recalculation is done based on TIME_TO_SOC_RECALCULATE_EVERY
 TIME_TO_GO_ENABLE = True
 
 ; --------- Time-To-Soc ---------

diff --git a/etc/dbus-serialbattery/jkbms_brn.py b/etc/dbus-serialbattery/jkbms_brn.py
@@ -34,7 +34,9 @@
     [["device_info", "sw_rev"], 30, "8s"],
     [["device_info", "uptime"], 38, "<L"],
     [["device_info", "vendor_id"], 6, "16s"],
-    [["device_info", "manufacturing_date"], 78, "8s"],
+    # disabled since some BMS throw a UnicodeDecodeError
+    # https://github.com/Louisvdw/dbus-serialbattery/discussions/485#discussioncomment-5694781
+    # [["device_info", "manufacturing_date"], 78, "8s"],
 ]
 
 TRANSLATE_SETTINGS = [