Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to cell voltage, temp and version #390

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Conversation

pchiquit
Copy link
Contributor

@pchiquit pchiquit commented Jan 5, 2023

This is a fix that corrects some issues with the original version of the EG4 LifePower support:

  • cell voltage needs to be masked for a high bit that sometimes is set. I suspect it indicates an alarm to the cell, but it should be masked or the voltage shows a spike
  • read hardware and firmware versions from the BMS itself. For my battery is produces firmware 3QT-YS00-16SV100A-V3.5 and the hardware version as "B".
  • add more temperature reading sensors. I'm not sure if they are used.
    I have been running it for at least 3 months with no issue, but I would welcome more testing.
    image

@Louisvdw Louisvdw merged commit 3b68ea6 into Louisvdw:master Jan 10, 2023
ppuetsch pushed a commit to ppuetsch/dbus-serialbattery that referenced this pull request Jan 11, 2023
* Fixes to cell voltage, temp and version

(cherry picked from commit 3b68ea6)
Louisvdw pushed a commit that referenced this pull request Jan 14, 2023
* bugfixes in midpoint calculation

* publish constants to dbus

* black and flake8

* update documentation

* Fixes to cell voltage, temp and version (#390)
(cherry picked from commit 3b68ea6)

* Automate release (#394)

* automate release generation

* make shell scripts +x

* add yaml

* rely on gh line ending conventions, simplify buildfiles.lst

* add gitattributes

* set file properties for run scripts to +x

Co-authored-by: Philip Puetsch <[email protected]>

(cherry picked from commit ce601fb)

* configure limits as fractions

* lint

* cleanup

* fixes

* remove development logging

Co-authored-by: Philip Puetsch <[email protected]>
Co-authored-by: pchiquit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants