ASP.NET Core 3.1 support #14
Conversation
Having a transitive dependency on Microsoft.AspNetCore.Mvc.Api.Analyzers causes build failures for projects that reference LtiAdvantage and a newer version of AspNetCore.
|
Full disclosure I'm a bit naive on the subject, but wonder what is gained by retargeting to netcoreapp3.1? My understanding is that the current netstandard2.0 target makes this library consumable across a wider range of framework impls and versions? Unfortunately we've backed ourselves into a corner where it will take some significant effort to upgrade to 3.1 in our current project. Is it possible to maintain a separate branch supporting netstandard2.0...or is this a case for multi-targeting? Happy to assist in the effort if anyone can provide some insight on best approach here. |
|
ASP.NET Core targets netcoreapp3.1 now, and the AssignmentGradeServices and NamesRoleProvisioningService have dependencies on Microsoft.AspNetCore packages. I briefly investigated splitting those components out into separate packages, which seemed like it would work, but was a more invasive change. Mutitageting is another option if 2.x support needs to be maintained; a couple Are you still using 2.2 even though it’s EOL? I had a couple projects I had to decided to either move up to 3.1 or back down to 2.1 to stay on a framework that would still get security updates. Fortunately they were simple, so I was able to upgrade them. It’s a bummer the 2.2 to 3.x upgrade path is difficult in some cases. |
Unfortunately. A significant portion of our dependencies target full framework so we've been facing the same decision. We'll likely end up moving back to 2.1 for security updates and then begin the refactoring in order to move forward. |
I'll update this PR to multi-target 2.1 and 3.1. |
Target netstandard2.0 and netcoreapp3.1 for LtiAdvantage and netcoreapp2.1 and netcoreapp3.1 for tests.
|
@srijken, can you (or another committer) review this please? |
|
@andyfmiller, can you review this please? |
| @@ -45,6 +45,7 @@ public async void AddScore_WhenScopeAllows(string scope, HttpStatusCode statusCo | |||
|
|
|||
| _client.DefaultRequestHeaders.Add("x-test-scope", scope); | |||
| var response = await _client.PostAsync(ScoresUrl, scoreContent); | |||
| var responseContent = await response.Content.ReadAsStringAsync(); | |||
There was a problem hiding this comment.
This line could be removed.
|
What's the process for getting this merged? |
|
Just thought I'd check in and see if there are plans to have the 3.1 changes merged into master. ?? |
|
Sorry about the delay in the merge! |
|
Thanks! |
No description provided.