Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code color breaks frequently #1599

Open
mkster opened this issue Sep 29, 2022 · 19 comments
Open

Code color breaks frequently #1599

mkster opened this issue Sep 29, 2022 · 19 comments
Labels
bug Something isn't working Info Needed More information is required

Comments

@mkster
Copy link

mkster commented Sep 29, 2022

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Other

Expected Behaviour

.

Actual Behaviour

Code coloring breaks frequently after doing edits
image

Reproduction steps

Not sure how to repro but it happens every day for me

Additional Notes

No response

Log File

No response

@sumneko
Copy link
Collaborator

sumneko commented Sep 30, 2022

Are you using plugin?
What is the version of the extension?

@sumneko sumneko added the Info Needed More information is required label Sep 30, 2022
@mkster
Copy link
Author

mkster commented Oct 3, 2022

@sumneko sumneko added bug Something isn't working and removed Info Needed More information is required labels Oct 9, 2022
@sumneko sumneko added this to the 3.6.0 milestone Oct 9, 2022
sumneko added a commit that referenced this issue Oct 10, 2022
@sumneko
Copy link
Collaborator

sumneko commented Oct 10, 2022

Could you please test if this commit fixed the issue?
You can manually apply this commit, or download server from https://github.com/sumneko/lua-language-server/actions/runs/3221180528

@sumneko sumneko added the Info Needed More information is required label Oct 11, 2022
@mkster
Copy link
Author

mkster commented Oct 13, 2022

yes seems to work, thank you

@mkster mkster closed this as completed Oct 13, 2022
@mkster
Copy link
Author

mkster commented Oct 13, 2022

Actually its still happening, this time it happened when I created a new file and used a snippet

@mkster mkster reopened this Oct 13, 2022
@sumneko
Copy link
Collaborator

sumneko commented Oct 13, 2022

Could you please provide a demo project?

@sumneko
Copy link
Collaborator

sumneko commented Oct 17, 2022

@mkster
Copy link
Author

mkster commented Oct 17, 2022

Just tried with this.

Created a new file, typed a few characters. Saved file as lua, removed the characters and used my snippet.

Getting this wrong error:
image

Using the first 'script component' snippet here https://github.com/AtomontageInc/vscode-atomontage-lua/blob/master/snippets/snippets.json

So far didnt see wrong colors but will test with this for a while.

@mkster
Copy link
Author

mkster commented Oct 19, 2022

Color broke again for me, it seems to happen less often now though

sumneko added a commit that referenced this issue Oct 24, 2022
need to resolve multi-lines before build proto, because proto cannot cross multi-lines.

#1599
@sumneko
Copy link
Collaborator

sumneko commented Oct 24, 2022

Please test this commit

@sumneko sumneko removed this from the 3.6.0 milestone Nov 7, 2022
@mkster
Copy link
Author

mkster commented Nov 17, 2022

Its still happening in v3.6.3. Seemed to have happened when I tabbed back into vscode

@mkster
Copy link
Author

mkster commented Nov 17, 2022

Aha! Finally found the way to reproduce.
It happens when using git ui. Do some changes and then press discard changes in source control. Now make a change in the file. Coloring is messed up
image

@sumneko
Copy link
Collaborator

sumneko commented Nov 23, 2022

Are you running in Non-Windows platform?
If yes, it maybe a filewatch issue.

@mkster
Copy link
Author

mkster commented Nov 23, 2022

I am using windows

@sumneko
Copy link
Collaborator

sumneko commented Nov 23, 2022

Is there a large number of files in your workspace?

@mkster
Copy link
Author

mkster commented Nov 23, 2022

Roughly 100 or less

@sumneko
Copy link
Collaborator

sumneko commented Nov 24, 2022

I still cannot reproduce, could you provide a demo project?

@FlashHit
Copy link

I just put this in here. As the title sounds like this issue could fit in here.

---@field test table<integer, { test: boolean }>

Check the >.
grafik

@sumneko
Copy link
Collaborator

sumneko commented Nov 24, 2022

I just put this in here. As the title sounds like this issue could fit in here.

---@field test table<integer, { test: boolean }>

Check the >. grafik

No, it's #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Info Needed More information is required
Projects
None yet
Development

No branches or pull requests

3 participants