Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #72: "[lua]: Couldn't find message for key config.*" console spam. #126

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

notpeter
Copy link
Contributor

@notpeter notpeter commented Oct 6, 2023

Currently when VSCode is launched from the CLI with code the console is spammed with a bunch of output. This fixes that.

I believe the errors occur because in Javascript: Boolean('') == false.

By replacing it with a placeholder value "TODO: Needs documentation" it becomes 'truthy' and no longer complains about missing messages.

@sumneko sumneko merged commit 7b58d50 into LuaLS:master Oct 7, 2023
6 checks passed
@sumneko
Copy link
Collaborator

sumneko commented Oct 7, 2023

Thank you! But it sounds like a VSCode issue. Maybe you could also submit a PR at the VSCode repository?

@notpeter
Copy link
Contributor Author

notpeter commented Oct 7, 2023

Yeah, I think that used to be microsoft/vscode-nls but now it's microsoft/vscode-l10n (aka @vscode/l10n-dev).

Maybe I'll take a peek.

@notpeter notpeter deleted the NLS_fix branch October 7, 2023 02:26
@aungkhant0911
Copy link

Not sure if it was fixed. I still have the same problem. Basically the extension host terminates as soon as .Lua file is opened.

`2023-10-25 03:17:43.128 [info] update#setState idle

2023-10-25 03:18:13.133 [info] update#setState checking for updates

2023-10-25 03:18:13.213 [info] update#setState idle

2023-10-25 03:18:27.655 [info] Extension host with pid 17704 exited with code: -1073741795, signal: unknown.

2023-10-25 03:18:27.655 [error] [UtilityProcess id: 1, type: extensionHost, pid: 17704]: crashed with code -1073741795 and reason 'crashed'

2023-10-25 03:18:28.336 [info] Extension host with pid 7756 exited with code: 0, signal: unknown.

2023-10-25 03:18:28.336 [error] [UtilityProcess id: 2, type: extensionHost, pid: 7756]: crashed with code -1073741795 and reason 'crashed'

2023-10-25 03:18:29.016 [info] Extension host with pid 15552 exited with code: 0, signal: unknown.

2023-10-25 03:18:29.028 [error] [UtilityProcess id: 3, type: extensionHost, pid: 15552]: crashed with code -1073741795 and reason 'crashed'





2023-10-25 03:17:45.830 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-dotnettools.dotnet-interactive-vscode' wants API proposal 'languageConfigurationAutoClosingPairs' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.

2023-10-25 03:17:45.840 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'github.copilot-chat' wants API proposal 'terminalContextMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.

2023-10-25 03:17:50.918 [info] [perf] Render performance baseline is 35ms

2023-10-25 03:18:04.031 [warning] [lua]: Couldn't find message for key config.diagnostics.circle-doc-class.

2023-10-25 03:18:04.032 [warning] [lua]: Couldn't find message for key config.diagnostics.inject-field.

2023-10-25 03:18:04.032 [warning] [lua]: Couldn't find message for key config.diagnostics.missing-fields.

2023-10-25 03:18:04.032 [warning] [lua]: Couldn't find message for key config.diagnostics.circle-doc-class.

2023-10-25 03:18:04.032 [warning] [lua]: Couldn't find message for key config.diagnostics.inject-field.

2023-10-25 03:18:04.033 [warning] [lua]: Couldn't find message for key config.diagnostics.missing-fields.

2023-10-25 03:18:04.033 [warning] [lua]: Couldn't find message for key config.runtime.builtin.basic.

2023-10-25 03:18:04.033 [warning] [lua]: Couldn't find message for key config.runtime.builtin.bit.

2023-10-25 03:18:04.033 [warning] [lua]: Couldn't find message for key config.runtime.builtin.bit32.

2023-10-25 03:18:04.033 [warning] [lua]: Couldn't find message for key config.runtime.builtin.builtin.

2023-10-25 03:18:04.033 [warning] [lua]: Couldn't find message for key config.runtime.builtin.coroutine.

2023-10-25 03:18:04.034 [warning] [lua]: Couldn't find message for key config.runtime.builtin.debug.

2023-10-25 03:18:04.034 [warning] [lua]: Couldn't find message for key config.runtime.builtin.ffi.

2023-10-25 03:18:04.034 [warning] [lua]: Couldn't find message for key config.runtime.builtin.io.

2023-10-25 03:18:04.034 [warning] [lua]: Couldn't find message for key config.runtime.builtin.jit.

2023-10-25 03:18:04.034 [warning] [lua]: Couldn't find message for key config.runtime.builtin.jit.profile.

2023-10-25 03:18:04.034 [warning] [lua]: Couldn't find message for key config.runtime.builtin.jit.util.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.math.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.os.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.package.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.string.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.string.buffer.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.table.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.table.clear.

2023-10-25 03:18:04.035 [warning] [lua]: Couldn't find message for key config.runtime.builtin.table.new.

2023-10-25 03:18:04.036 [warning] [lua]: Couldn't find message for key config.runtime.builtin.utf8.

2023-10-25 03:18:04.036 [warning] [lua]: Couldn't find message for key config.runtime.fileEncoding.utf8.

2023-10-25 03:18:04.036 [warning] [lua]: Couldn't find message for key config.runtime.fileEncoding.ansi.

2023-10-25 03:18:04.036 [warning] [lua]: Couldn't find message for key config.runtime.fileEncoding.utf16le.

2023-10-25 03:18:04.036 [warning] [lua]: Couldn't find message for key config.runtime.fileEncoding.utf16be.

2023-10-25 03:18:04.036 [warning] [lua]: Couldn't find message for key config.runtime.version.Lua 5.1.

2023-10-25 03:18:04.037 [warning] [lua]: Couldn't find message for key config.runtime.version.Lua 5.2.

2023-10-25 03:18:04.037 [warning] [lua]: Couldn't find message for key config.runtime.version.Lua 5.3.

2023-10-25 03:18:04.037 [warning] [lua]: Couldn't find message for key config.runtime.version.Lua 5.4.

2023-10-25 03:18:04.037 [warning] [lua]: Couldn't find message for key config.runtime.version.LuaJIT.

2023-10-25 03:18:27.660 [error] Extension host (LocalProcess) terminated unexpectedly. No extensions were activated.

2023-10-25 03:18:27.660 [info] Automatically restarting the extension host.

2023-10-25 03:18:28.359 [error] Extension host (LocalProcess) terminated unexpectedly. No extensions were activated.

2023-10-25 03:18:28.359 [info] Automatically restarting the extension host.

2023-10-25 03:18:29.032 [error] Extension host (LocalProcess) terminated unexpectedly. No extensions were `activated.``

@carsakiller
Copy link
Collaborator

@aungkhant0911 you appear to have a larger problem that what this PR is about. The VS Code extension host (the runtime that runs all extensions) crashing is unrelated but concerning. Can you try disabling all extensions except for the Lua extension and try to replicate the issue? If it persists with the Lua extension, please open an issue.

As for the Lua log messages, there has not been a release yet that contains this fix.

@aungkhant0911
Copy link

aungkhant0911 commented Oct 26, 2023

I only have one extension and that is this one. Other extensions which were uninstalled (because I was testing) worked just fine. Eg; Pylance/Python debug codes just fine. Only this one got a problem.

Fyi, I have downgraded to at least 6 versions now............

@notpeter
Copy link
Contributor Author

Please open a new issue. This issue is related to a bunch of excessive warnings that are outputted to the console.

You are seeing these but they are harmless and unrelated to your crashing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants