Always treat profile values as templates, prevent template infinite recursion #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a major drawback, which is we may end up rendering things that the user doesn't want rendered. This is preventable by making template keys escapable, but that's a bunch of work so I'm punting on it for now. Definitely important though.
Templates are limited to 10 recursive calls total now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile values are always treated as templates. This is technically a breaking change but in reality it probably won't break anyone's setup. This opens the door to making command arguments and file paths templated as well, which greatly increases the power of chains and templates.
A bonus of this is it deletes a ton of shitty deserialization code.