Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error loading requests with empty header values from history #402

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Oct 21, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Just a simple parsing bug. I assumed header values couldn't be empty, which is wrong. I DID confirm that empty header names are invalid (not allowed by the http crate) so don't need to worry about that.

Closes #400

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

This is a temporary fix. I'd love to use a library for the parsing, but it's not clear if I can tap into reqwest/hyper/httparse to do this, so I need to work on it a bit more.

QA

How did you test this?

Manually :(

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering merged commit 26aefa0 into master Oct 21, 2024
15 checks passed
@LucasPickering LucasPickering deleted the header-encoding-error branch October 21, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching request ... from database - Conversion error
1 participant