Fix error loading requests with empty header values from history #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
Just a simple parsing bug. I assumed header values couldn't be empty, which is wrong. I DID confirm that empty header names are invalid (not allowed by the
http
crate) so don't need to worry about that.Closes #400
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
This is a temporary fix. I'd love to use a library for the parsing, but it's not clear if I can tap into reqwest/hyper/httparse to do this, so I need to work on it a bit more.
QA
How did you test this?
Manually :(
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?