Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve key order of objects in JSON responses #406

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Oct 23, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Enable preserve_order feature flag of serde_json so it uses IndexMap internally instead of HashMap. We're already pulling in indexmap as a dependency.

Closes #405

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

  • Duplicated dependency. I confirmed it isn't with cargo tree -i -p indexmap, only one version is present
  • Response ordering changes for users. Not a big deal

QA

How did you test this?

Manually in TUI

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) October 23, 2024 01:48
@LucasPickering LucasPickering merged commit ac9249a into master Oct 23, 2024
15 checks passed
@LucasPickering LucasPickering deleted the preserve-key-order branch October 23, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve original sorting
1 participant