Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore_certificate_hosts and large_body_size config fields #408

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Oct 26, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Little oopsie here

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

This is technically a breaking change, so if anyone was working around the bug with the http section, it will break for them. I'm still considering it just a bug fix though, because it was not working as documented.

QA

How did you test this?

Manual

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) October 26, 2024 19:07
@LucasPickering LucasPickering merged commit d944d1f into master Oct 26, 2024
15 checks passed
@LucasPickering LucasPickering deleted the fix-config branch October 26, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant