Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This is a primitive implementation of opening recipe/request/response bodies in an external viewer (AKA pager). It adds an action menu item titled "View Body" that opens a subprocess to run the pager. There are a lot of improvements I'd like to make:
default
andjson
would be the only two options for now)Closes #404
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
This is a half-baked implementation, so there's the risk I need to make breaking changes in the future. I'm not too worried about that though, because the only thing that could really break is the config schema, and that's simple enough to keep backward compatible.
QA
How did you test this?
Manual testing. It's tough to write a unit test for and I am feeling supremely lazy.
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?