Migrate to ts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dobri9909
reviewed
Jun 19, 2020
Dobri9909
reviewed
Jun 19, 2020
Dobri9909
reviewed
Jun 19, 2020
Dobri9909
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
nikksan
reviewed
Jun 19, 2020
zupper
reviewed
Jun 22, 2020
src/LoggerFactory.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| import ConsoleLogger from './adapters/ConsoleLogger'; | |||
| import AbstractLogger from './AbstractLogger'; | |||
There was a problem hiding this comment.
Why have an AbstractLogger AND a ConsoleLogger if we're going to be dependent on both? The actual logger implementation should be dependency-injected at construction-time. Otherwise it doesn't make much sense to have it split into an "abstract" class and an implementation class.
There was a problem hiding this comment.
Done, removed the redundant explicit return type.
MaDKaTZe
suggested changes
Jun 23, 2020
MaDKaTZe
suggested changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.