Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes android accessibility handling #94

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

IeuanWalker
Copy link
Contributor

#93

Things changed in this PR -

  • Removed AndroidTalkbackAccessibilityWorkaround, this was left over from the Xamarin.Forms implementation and wasn't actully being used in the Maui version
  • Added DisableAndroidAccessibilityHandling
    • I don't imagine a lot of people needing to use this, but just prevents people adding workarounds like the one mentioned in the comments of the linked issue
  • Main fix to the linked issue is keeping a list of the android views that the accessibility handling was ran against to disable the focusability of the elements. It then uses that list to re-enable the focusability

@LuckyDucko
Copy link
Owner

@IeuanWalker great stuff! Thanks for the PR.

Just wanted to leave a comment, i am out on my honeymoon in Japan until the end of the month, if i don't start merging PR's in December bump this and I'll jump on it!

@IeuanWalker
Copy link
Contributor Author

No prob, congrats 🎉 enjoy ur honeymoon 😀

@LuckyDucko LuckyDucko merged commit a060c43 into LuckyDucko:master Nov 30, 2023
1 check passed
@troy-ob
Copy link
Contributor

troy-ob commented Dec 1, 2023

Hi

thanks for the fix @IeuanWalker and thanks for the merge @LuckyDucko :)

Do you have any plans for a new NuGet package with the latest changes?

@LuckyDucko
Copy link
Owner

Yeah i just need to pay a bit more attention to the last PR i need to merge, then i'll do a touch of testing and try to fire something out.

Getting held up by putting up holiday lights, but lets all hope for a christmas miracle and a speedy release ;)

@troy-ob
Copy link
Contributor

troy-ob commented Jan 8, 2024

Heya @LuckyDucko

I hope you had a nice Christmas and a good start to 2024 :)

Just wanted to ask again if you have an ETA of a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants