Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra (currently no-op) args to support IntelliJ Rust #28

Closed
wants to merge 2 commits into from

Conversation

Dinnerbone
Copy link

This partially gets us to working in IntelliJ Rust - #25.

When we do JSON support we should gate it behind -Z unstable-options as the json format isn't stable yet. This matches the official libtest behaviour.

Copy link
Owner

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Looks good, only the docs need some tweaking.

#[arg(long = "show-output")]
pub show_output: bool,

/// Enable nightly-only flags
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say something like this:

Suggested change
/// Enable nightly-only flags
/// No-op, ignored. Flag only exists for CLI compatibility with libtest.

The libtest description doesn't really make sense in the context of libtest-mimic.

@@ -46,6 +46,14 @@ pub struct Arguments {
#[arg(long = "nocapture", help = "No-op (libtest-mimic always runs in no-capture mode)")]
pub nocapture: bool,

/// No-op, ignored (libtest-mimic doesn't support this)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// No-op, ignored (libtest-mimic doesn't support this)
/// No-op, ignored. libtest-mimic does not currently capture stdout.

/// Possible values for the `-Z` option
#[derive(Debug, Clone, Copy, PartialEq, Eq, ValueEnum)]
pub enum UnstableFlags {
/// Allow use of experimental features
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I think I would just remove this line. As this flag is completely ignored, using the libtest description will likely confuse people.

@LukasKalbertodt
Copy link
Owner

As I haven't heard back, I will close this PR. If you want to take another stab at this, feel free to reopen or open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants