Include the kind of test while matching filters #30
Conversation
There was a problem hiding this comment.
Thanks for the PR. Seems like a reasonable idea to also match the kind.
I left one comment that still worries me. And please remove the rustfmt changes so that this PR only contains the changes for the behavior change. Plus the copy&paste comment that the other reviewer found.
Consider a trial with name "my_test" and kind "foo". The text that gets printed out with `--list --format terse` is: ``` [foo] my_test: test ``` With libtest, an invariant is that the part of the string before ": test" can be passed into "--exact" to run that test. However, that invariant is currently not upheld by libtest-mimic: it only matches against the name of the test and not the kind. Make it so that libtest-mimic also matches against the kind of test, not just its name. I also took the liberty of running rustfmt (or really, my editor automatically ran it when I went in to edit the file.)
Would you be open at all to formatting the code via rustfmt, maybe as a separate change? To be honest this is a huge discouragement for me to contribute (and why I didn't get around to this for many months), because my editor is set up to autoformat on save, and rustfmt is used by every single one of the ~100 Rust projects I've ever contributed to. |
Unfortunately, not at this time, no. I just checked all the changes made by And FWIW, my editor is also set up to do certain things automatically on save (removing trailing whitespace, ...). But if I contribute to some project that does not adhere to this basic code hygiene, I will disable it temporarily. Or more likely, just don't stage those changes before a commit. Personally I think that's no big deal. That's just some explanation why things are the way they are. |
|
Released as v0.7.0 |
Consider a trial with name "my_test" and kind "foo". The text that gets printed out with
--list --format terseis:With libtest, an invariant is that the part of the string before ": test" can be passed into "--exact" to run that test. However, that invariant is currently not upheld by libtest-mimic: it only matches against the name of the test and not the kind. This breaks nextest's ability to run these tests: nextest-rs/nextest#836
Make it so that libtest-mimic also matches against the kind of test, not just its name.
I also took the liberty of running rustfmt (or really, my editor automatically ran it when I went in to edit the file.)