Add JSON support #35
Merged
Add JSON support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
force-pushed
the
add-json-support
branch
from
f135574
to
3bb5e83
Compare
Closes #1
Co-Authored-By: Timo <[email protected]>
That was fairly annoying because of the JSON literal in the test. Using raw strings is good to not need to escape all the quotes, but it makes it super hard to split a line. Just putting it into a new file is probably the best idea.
LukasKalbertodt
force-pushed
the
add-json-support
branch
from
3bb5e83
to
431df0d
Compare
|
Thanks @PaulWagener and @t-moe! |
This was referenced Jan 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extracted from #34 which in turn used a commit from #33.