Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h5p-mongos3: incorrect export #1069

Closed
sr258 opened this issue Feb 18, 2021 · 0 comments
Closed

h5p-mongos3: incorrect export #1069

sr258 opened this issue Feb 18, 2021 · 0 comments

Comments

@sr258
Copy link
Member

sr258 commented Feb 18, 2021

The way h5p-mongos3 makes importing individual classes impossible:
destructuring with import { MongoS3ContentStorage } from '@lumieducation/h5p-mongos3'; doesn't work. I think we have to remove the default export
sr258 added a commit that referenced this issue Feb 18, 2021
@sr258
fix(h5p-mongos3): fixed default export
82f9cf5 
Closes h5p-mongos3: incorrect export #1069
@sr258 sr258 mentioned this issue Feb 18, 2021
Merged
sr258 added a commit that referenced this issue Feb 19, 2021
@sr258
fix(h5p-mongos3): fixed default export (#1070)
b25dbaa 
Closes h5p-mongos3: incorrect export #1069
@sr258 sr258 closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sr258