Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H5PEditor.getLibraryData: Improve error-message when library is not found #233

Closed
JPSchellenberg opened this issue Nov 4, 2019 · 1 comment · Fixed by #265
Closed

H5PEditor.getLibraryData: Improve error-message when library is not found #233

JPSchellenberg opened this issue Nov 4, 2019 · 1 comment · Fixed by #265
Labels
released [type] bug Something isn't working (resulting in patch-version)

Comments

@JPSchellenberg
Copy link
Member

JPSchellenberg commented Nov 4, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Right now, when I use getLibraryData() for a non-existant library and I catch it, I get the error-object TypeError: Cannot read property 'preloadedDependencies' of undefined, which is not very helpful.

Describe the solution you'd like
I would like receive an error-object that tells me what went wrong. Like:
Library xyz was not found.
@JPSchellenberg JPSchellenberg added [type] feature Changes that introduce a new feature (resulting in minor-version-bump) [type] bug Something isn't working (resulting in patch-version) and removed [type] feature Changes that introduce a new feature (resulting in minor-version-bump) labels Nov 4, 2019
@sr258 sr258 closed this as completed Nov 18, 2019
@sr258 sr258 mentioned this issue Nov 20, 2019
Merged
JPSchellenberg pushed a commit that referenced this issue Nov 25, 2019
@sr258 @JPSchellenberg
fix(h5p-editor): improve error messages (#265)
7ed5a68 
* fix(h5p-editor): Improved error message when requesting uninstalled library data (#233)

* fix(Content Type Cache): The cache is now automatically downloaded if it hasn't been called before

* fix(h5p-editor): Improved error message when saving content with invalid library name

* fix(h5p-editor): Improved error messages
@JPSchellenberg
Copy link
Member Author

🎉 This issue has been resolved in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released [type] bug Something isn't working (resulting in patch-version)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(h5p-editor): Improved error messages Lumieducation/H5P-Nodejs-library
2 participants
@JPSchellenberg @sr258