fix(library management): removed id and libraryId properties of installed libraries (resolves #203) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPSchellenberg
approved these changes
Dec 2, 2019
|
🎉 This PR is included in version 0.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IInstalledLibraryhad the propertiesidandlibraryIduntil now. I've removed those and the client still works fine. I'm quite certain that they are only artifacts of the relational database schema used by the PHP implementation to store the libraries. The ids are fully redundant as normally the system uses the "ubername" to uniquely identify installed libraries. (All endpoints I've implemented so far always used the ubername and never an numericid). Even Joubel uses the name "id" for the machine name in the editor client, so I assume that the "library ids" in the PHP editor server are only internal and don't have to imitated. We can still re-introduce later them if needed after all.